Skip to content

Conversation

hestro
Copy link
Member

@hestro hestro commented Sep 13, 2026

Adds a responsive grid of book cards, using mock data for now.

Changes include:

  • Added Book interface and mock book data
  • Added BookCard component with styling
    • The .favoriteButton in BookCard.tsx is currently not doing anything, and is just a placeholder for later development
  • Added BookGrid component with styling using a responsive grid of BookCards

BookGrid is currently rendered directly in App.tsx's main content area. This may change if a different page structure makes more sense later, or if additional components need to be built around BookGrid.

Note: This is my first time working with React - so don't hesitate to give feedback.

Closes #5

@hestro hestro added the enhancement New feature or request label Sep 13, 2026
@hestro hestro self-assigned this Sep 13, 2026
@hestro hestro requested a review from a team as a code owner September 13, 2026 02:22
@hestro hestro linked an issue Sep 13, 2026 that may be closed by this pull request
@martakam martakam changed the base branch from feat/basic-layout to main September 13, 2026 12:47
@martakam
Copy link
Member

Changed the base branch to main, as I'm assuming you'd like this merged there, not into the other branch used in #6

martakam
martakam previously approved these changes Sep 13, 2026
Copy link
Member

@martakam martakam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as well! Left a small comment on usage of a CSS class.

@martakam martakam mentioned this pull request Sep 13, 2026
hestro and others added 2 commits September 13, 2026 18:22
Co-authored-by: Martin Alexander Kaminski <martakam@stud.ntnu.no>
Co-authored-by: Martin Alexander Kaminski <martakam@stud.ntnu.no>
@hestro hestro requested a review from martakam September 13, 2026 16:23
martakam
martakam previously approved these changes Sep 13, 2026
@hestro hestro dismissed martakam’s stale review September 13, 2026 16:40

The merge-base changed after approval.

martakam
martakam previously approved these changes Sep 13, 2026
Copy link
Member

@martakam martakam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other PR does not introduce any breaking changes to this one. Approving again.

@hestro hestro dismissed martakam’s stale review September 13, 2026 16:52

The merge-base changed after approval.

Copy link
Member

@martakam martakam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently the PR needs to completely up to date with the base branch in order to merge. Interesting.

@hestro hestro merged commit 8d09c63 into main Sep 13, 2026
@martakam martakam deleted the feat/book-grid branch September 17, 2026 22:38
Sign in to join this conversation on GitHub.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add book grid components displaying book cards
2 participants